Fix ReflectionProperty::getRawValue(), setRawValue(), setRawValueWithoutLazyInitialization() for properties overridden with hooks #17714
Conversation
…and flags in ReflectionProperty::getRawValue(), setRawValue(), setRawValueWithoutLazyInitialization()
| } | ||
|
|
||
| if (!ref->prop || !ref->prop->hooks || !ref->prop->hooks[ZEND_PROPERTY_HOOK_GET]) { | ||
| if (!prop || !prop->hooks || !prop->hooks[ZEND_PROPERTY_HOOK_GET]) { |
There was a problem hiding this comment.
The reason I originally used zend_read_property_ex() was to avoid replicating its behavior for things like typed uninitialized properties, and readonly properties for write. I suppose that if this gets too tedious, it might be easier to handle these two things, and just access the backing value explicitly. Luckily, prop_info->offset stays the same in child properties, and child properties cannot become virtual, so we could avoid loading the latest property info.
There was a problem hiding this comment.
I've tried that initially in #17698, but there are other cases to handle, e.g. type checking for writes, and existing code is hard to re-use (e.g. zend_assign_to_typed_prop() can not be called outside of execute_ex due to execute_data being a register and I fear that trying to make it re-usable will lead to performance regressions).
reflection_property_get_effective_prop() turns out to be quite simple, so I think I will leave it like this.
#17698 will revert potential performance regressions in the simple case.
2 participants
Fixes GH-17713.
new ReflectionProperty($scope, $propName)keeps a reference to thezend_property_infoof$propNamedeclared in$scope. IngetRawValue()and related methods, we use this reference to check whether the property is hooked.However, calling
new ReflectionProperty($scope, $propName)->getRawValue($object)is equivalent to the expression$object->$propNamefrom scope$scope(except that it bypasses hooks), and thus may access an overridden property (unless the original is private). This property may have hooks and different flags.Here I fetch the effective property info before checking for hooks and property flags.